Norm path before compare #11719
Merged
Norm path before compare #11719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind investigating using pathlib.Path for this block of code instead? It should allow more succinct code for the same logic. |
lorddavidiii
force-pushed
the
norm-path-before-compare
branch
from
e67d631 to
52a6318
Compare
uranusjr
reviewed
Jan 11, 2023
|
hm, the failing tests looks unrelated this PR to me, or? |
|
Looks like the CI stack had some (hopefully temporary) downtime. |
uranusjr
approved these changes
Jan 16, 2023
pradyunsg
force-pushed
the
norm-path-before-compare
branch
from
04bcf51 to
9f02064
Compare
|
@lorddavidiii Thanks for filing this PR and for exploring the migration of this function to pathlib! ^.^ I've rebased this PR on I think the pathlib variant is harder to read and follow than the original function. We can discuss any "should this change to pathlib" related concerns there. |
uranusjr
approved these changes
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR norms the paths before checking, if the installed scripts are on
PATH. I got wrong warnings, when the PATH contains something like/a/./bininstead of/a/bin.I also add a small test for this, contains all the cases from the os.path.normpath() docs. I am not sure, if this works also on windows
and I am also not sure, if I should add a news fragment, as this is just a small change.